[ntuple] Improve error reporting consistency #18672
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be consistent with other misuses of fields and their constructors, and also matches RCardinalityField.
R__ASSERT is also included in Release builds, and this seems more consistent with other places for unhandled enum values (for example RNTupleReader::PrintInfo or VisitCardinalityField).
enirolf
reviewed
May 9, 2025
silverweed
reviewed
May 9, 2025
silverweed
approved these changes
May 9, 2025
Test Results 19 files 19 suites 4d 2h 18m 57s ⏱️ For more details on these failures, see this check. Results for commit 42fa14f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RExceptionfor field misuse,R__ASSERT(false)for unhandled column types.