Skip to content

Version 0.14.0-rc.1, update README #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 4, 2025
Merged

Version 0.14.0-rc.1, update README #139

merged 3 commits into from
May 4, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 4, 2025

No description provided.

@cknitt cknitt requested a review from Freddy03h May 4, 2025 09:59
Freddy03h
Freddy03h previously approved these changes May 4, 2025
View reviewed changes
@Freddy03h
Copy link
Collaborator

Freddy03h commented May 4, 2025 •
edited
Loading

I forgot: maybe also upgrade react and react-dom versions in peerDependencies ? (and also in devDependencies ?)

@cknitt cknitt requested a review from Freddy03h May 4, 2025 15:05
@Freddy03h
Copy link
Collaborator

Freddy03h commented May 4, 2025 •
edited
Loading

The only missing thing about React 19 is ref as a prop
https://react.dev/blog/2024/12/05/react-19#ref-as-a-prop

But, according to @cknitt, the issue

Ref cannot be passed as a normal prop. Please use forwardRef API instead.

is on JSX PPX in rescript project, so I think it's done for rescript-react

@cknitt cknitt merged commit caed8c9 into master May 4, 2025
1 check passed
@cknitt cknitt deleted the version-0.14 branch May 4, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freddy03h Freddy03h Freddy03h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @Freddy03h