-
Notifications
You must be signed in to change notification settings - Fork 754
Patch 1 #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 #926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One comment on a note in the markdown that won't show.
README.md
Outdated
<%= react_component("HelloWorld", { greeting: "Hello" }) %> | ||
7) [Render it in a Rails view](#view-helper): | ||
|
||
```erb: paste this in view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment will be lost as the erb
text is a hint to the formatter. Could you add the extra text as a note below the numbered list above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. its done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added common error section with yarn update fix. This may help beginner's setup.added erb comment
README.md
Outdated
<%= react_component("HelloWorld", { greeting: "Hello" }) %> | ||
7) [Render it in a Rails view](#view-helper): | ||
|
||
```erb: paste this in view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. its done.
Thanks for the contribution 👍 |
Summary
Formatted and structured the setup process of the react-rails to make it easy.