Skip to content

Patch 1 #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2018
Merged

Patch 1 #926

merged 3 commits into from
Sep 15, 2018

Conversation

codevedas
Copy link
Contributor

Summary

Formatted and structured the setup process of the react-rails to make it easy.

Copy link
Member

@BookOfGreg BookOfGreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment on a note in the markdown that won't show.

README.md Outdated
<%= react_component("HelloWorld", { greeting: "Hello" }) %>
7) [Render it in a Rails view](#view-helper):

```erb: paste this in view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment will be lost as the erb text is a hint to the formatter. Could you add the extra text as a note below the numbered list above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. its done.

Copy link
Contributor Author

@codevedas codevedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added common error section with yarn update fix. This may help beginner's setup.added erb comment

README.md Outdated
<%= react_component("HelloWorld", { greeting: "Hello" }) %>
7) [Render it in a Rails view](#view-helper):

```erb: paste this in view
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. its done.

@BookOfGreg BookOfGreg merged commit 732a489 into reactjs:master Sep 15, 2018
@BookOfGreg
Copy link
Member

Thanks for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants