Skip to content

Support webpacker in generators #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2017
Merged

Support webpacker in generators #684

merged 3 commits into from
Apr 5, 2017

Conversation

rmosolgo
Copy link
Member

@rmosolgo rmosolgo commented Apr 5, 2017 •
edited
Loading

  • Component generator outputs to the configured webpacker source
  • Install generator adds to webpacker files

@rmosolgo rmosolgo mentioned this pull request Apr 5, 2017
Closed
13 tasks
@rmosolgo
Copy link
Member Author

rmosolgo commented Apr 5, 2017

While writing the template for the server_rendering.js pack, I realized the current JS call for server rendering won't work, because it's coupled to component-names-as-globals. So I rejiggered it a bit, now it calls a method on ReactRailsUJS instead.

@rmosolgo rmosolgo merged commit ce68d57 into 2.0-dev Apr 5, 2017
@rmosolgo rmosolgo deleted the generate-webpacker branch April 5, 2017 20:32
@rmosolgo rmosolgo added this to the 2.0.0 milestone Apr 5, 2017
@brentdodell
Copy link

This was broken, I believe this Webpacker change. Webpacker::Configuration should now be Webpacker.config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rmosolgo @brentdodell