feat(UJS) show helpful error messages for missing components #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Problem ----------- Currently, if you use an invalid component name in `data-react-class`, you get a React invariant error that only tells you that the component class was undefined, but it doesn't actually help you fix the error. I end up needing to scroll backwards in the stack trace until I find this part of the `react_ujs_mount.js` code and inspect the value of `className` The Solution ------------ Throw a helpful error (and nice console log message) about an invalid className at the moment we try to mount the component.
|
🎉 thanks, that's awesome! this will prevent a lot of github issues, too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Currently, if you use an invalid component name in
data-react-class,you get a React invariant error that only tells you that the component
class was undefined, but it doesn't actually help you fix the error. I
end up needing to scroll backwards in the stack trace until I find this
part of the
react_ujs_mount.jscode and inspect the value ofclassNameThe Solution
Throw a helpful error (and nice console log message) about an invalid
className at the moment we try to mount the component. You can even right-click
and
Reveal in Elements Panelto see exactly where the element is in the DOM!