Integration with appraisal #4
Conversation
|
Awesome! Comments incoming inline |
| @@ -0,0 +1,11 @@ | |||
| appraise "rails31" do | |||
There was a problem hiding this comment.
I'm going to be unnecessarily picky and ask for better naming of these. rails-3.1, rails-3.2, rails-4.0 (unless that breaks things but I don't think it did)
There is no reason to keep them. Just as we don't keep Gemfile.lock for a gem, there is no point in enforcing particular version of gems when testing different versions of rails with appraisal.
|
Well, if you consider this article by Yehuda I don't see any reason to keep gemfile locks for different rails versions. We should be compatible with what we define as dependencies, not with particular versions of gem. For now it works fine, but I'll ask someone about it. |
|
Thoughtbot recommends we keep the .lock files checked in too (https://github.com/thoughtbot/appraisal/blob/master/README.md#version-control) so let's do that. I was just wishing that file didn't include specific user info in there. I don't think that removing that part of the file is actually a good idea, I don't know what side effects it would have. |
|
OK, I'll keep an eye on this: thoughtbot/appraisal#49 |
|
Sorry for letting this linger! I'm going to merge in and then if there are any followups we can deal with them then. Thanks for working on this! |
Integration with appraisal. Closes #1
Hey,
So I took a look at it. I think main source of the problem was that you generated rails 4.0 app, it would probably be easier to upgrade generated 3.1 or 3.2 but I downgraded dummy to be compatible with 3.1 - 4.0
[Edit] You will probably have some suggestions, even though it is an early version. Integration with Appraisal should, however, not really change much, if at all. It is mostly implemented similarly to many other repos.