Skip to content

feat(JS) add webpack build process #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2015
Merged

feat(JS) add webpack build process #376

merged 2 commits into from
Oct 22, 2015

Conversation

rmosolgo
Copy link
Member

Here's my best guess at how to update to React 0.14:

  • Write manifests for server/browser, no-addons/with-addons
  • Build the manifests with Webpack
  • Copy them into the gem source, just like the old React.js files
  • Longer discussion: Update to React 0.14 #365

Other changes:

  • Server rendering uses ReactDOMServer and react-server.js
  • Split the rake task into two (update = build + copy)

Lol:
image

@rmosolgo
Copy link
Member Author

@zpao Could you take a look at the JavaScript side of this? I think this is an OK way to use the new JS modules in the browser & server, but I'm a bit out of my element!

@rmosolgo
Copy link
Member Author

looks good in my own app, here goes!

rmosolgo pushed a commit that referenced this pull request Oct 22, 2015
feat(JS) add webpack build process
@rmosolgo rmosolgo merged commit e409a62 into reactjs:master Oct 22, 2015
@rmosolgo rmosolgo deleted the build-with-webpack branch October 22, 2015 19:28
@zpao
Copy link
Member

zpao commented Oct 27, 2015

Sorry for the delay, this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants