Fix asset path munging to work in production env. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! It's getting merged as soon as @zpao will confirm your CLA. |
jtmalinowski
added a commit
that referenced
this pull request
Mar 31, 2014
Fix asset path munging to work in production env.
|
@johnthethird this seems to be causing #148 sporadically. |
|
I've also asked here: rails/sprockets-rails#227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #31 by changing the initializer method. If you use
after_initializeyou can't then change the Sprockets path in production mode, as it becomes immutable.Also, clean up the way the variant configs are initialized to fix issue #11.
I pulled out these specific changes from my server-rendering branch, so that they do not depend at all on server-rendering. I will rebase the server rendering changes on top of this so that they can be pulled in separately at the appropriate time.