feat(ExecJSRenderer) add ExecJSRenderer #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
ExecJSRenderer
was created while testing server rendering performance and I thought it might be a chance to reorganize server rendering code. In this branch:ExecJSRenderer
is basically a wrapper around ExecJSSprocketsRenderer
is anExecJSRenderer
which fetches source JS from the asset pipeline & enables "console replay"What do you think?
Pros:
#before_render
and#after_render
hooks add extensibility as requested in Decouple renderer #253 (comment)react-rails
, maybe people will make their ownCons:
renderToString
andrenderToStaticMarkup
? Right now, that's very awkward.react-rails
depends on sprockets, why wouldn't you useSprocketsRenderer
?Anyways, curious what others think of this change!