Rspec tests fail due to tilt dependency
#248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to [#243](https://github.com/reactjs/react-rails/pull/243/files) I am using react-rails as dependency in a gem I created and running rspec in that gem throws the following error: $ rspec /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react/jsx/template.rb:1:in `require': cannot load such file -- tilt (LoadError) from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react/jsx/template.rb:1:in `<top (required)>' from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react/jsx.rb:3:in `require' from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react/jsx.rb:3:in `<top (required)>' from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react-rails.rb:1:in `require' from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react-rails.rb:1:in `<top (required)>' ... This happens because react-rails requires tilt here. I've noticed that adding tilt as a dependency in the gemspec solves this issue and all other tests run without a problem.
|
cc @rmosolgo just a heads up here, looks like this makes the tests actually pass again :) |
|
👍 weird that this affects the tests but I'll take it! good catch! (I thought tilt was a dependency of rails, I guess not so!) |
rmosolgo
pushed a commit
that referenced
this pull request
Apr 21, 2015
Rspec tests fail due to `tilt` dependency
gbanis-fiksu
added a commit
to gbanis-fiksu/react-rails
that referenced
this pull request
May 27, 2015
For more info look at PRs [248](reactjs#248) and [243](reactjs#243).
gbanis-fiksu
added a commit
to gbanis-fiksu/react-rails
that referenced
this pull request
May 27, 2015
For more info look at PRs [248](reactjs#248) and [243](reactjs#243).
This was referenced May 27, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #243
I am using react-rails as dependency in a gem I created and running rspec in that gem throws the following error:
$ rspec
/Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react/jsx/template.rb:1:in
require': cannot load such file -- tilt (LoadError) from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react/jsx/template.rb:1:in<top (required)>'from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react/jsx.rb:3:in
require' from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react/jsx.rb:3:in<top (required)>'from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react-rails.rb:1:in
require' from /Users/gbanis/.rvm/gems/ruby-2.0.0-p598/gems/react-rails-0.13.0.0/lib/react-rails.rb:1:in<top (required)>'...
This happens because react-rails requires tilt here.
I've noticed that adding tilt as a dependency in the gemspec solves this issue and all other tests run without a problem.