Skip to content

README update #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2015
Merged

README update #145

merged 1 commit into from
Jan 19, 2015

Conversation

uberllama
Copy link
Contributor

The README me shows unnecessary double nesting on the jbuilder example. Corrected to use standard collection syntax.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rmosolgo
Copy link
Member

I don't know the first thing about jbuilder, @xionon what do you think of this?

@uberllama
Copy link
Contributor Author

Would it help if I said "trust me"? :) I've used it on many projects and this is standard wrapped collection syntax. You very rarely use array! in Jbuilder, precisely because you typically need to support multiple nodes on a response.

@rmosolgo
Copy link
Member

Haha, I trust you, but I wouldn't be doing a good job if I didn't double check :P

I'll give it a try later if we don't here from xionon. I figured I'd ask him since he wrote that feature to start with!

@xionon
Copy link
Contributor

xionon commented Jan 19, 2015

Same output, simpler syntax, 👍 from me

@rmosolgo
Copy link
Member

💥 Thanks guys!

rmosolgo pushed a commit that referenced this pull request Jan 19, 2015
@rmosolgo rmosolgo merged commit 85a27bc into reactjs:master Jan 19, 2015
@uberllama
Copy link
Contributor Author

kaplah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants