Call handleUnmount before rendering a new page #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge this just now. Thanks for contributing. If you could throw in a test to ensure it's not toggled back accidentally in another PR I'd really appreciate it also! |
|
@BookOfGreg Would be great if we could get a new release with this fix included with react_ujs v2.6.0 the callback componentWillUnmount isn't triggered. |
|
@jnstq Yep I'll try get a release out at the weekend. I hate releasing while the tests don't pass but I can't really help that my dependencies didn't follow semver. |
|
@BookOfGreg Just checking the status of this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UJS would mount non permanent react components multiple times when navigating away and then back to a page with one.
Other Information
This was modified back in July in this commit. It appears as if it might have been modified unintentionally.