Skip to content

feat: textlint (#971 #926) #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

lumirlumir
Copy link
Collaborator

@lumirlumir lumirlumir commented Jul 24, 2024

안녕하세요😊 textlint에 Translate Glossary 일반에 존재하는 용어를 추가하였습니다.

이제, '번역하면 안되는 용어'만 추가하면 textlint 작업이 완료됩니다.

특이사항은 아래와 같습니다.

  1. 'Note'라는 용어는 wiki에서 '주의' 및 '중요합니다!' 라는 2개의 용어로 번역되어 있습니다. 하지만, 실제 ko.react.dev에서는 '중요합니다!' 로만 번역되어져 사용되기 때문에, '주의'를 삭제하고 '중요합니다!'만 남겨두었습니다.
  2. 'Returns' 용어의 정규표현식에 {/ 문자열을 뒷부분에 추가한 이유는, 제목에 사용된 'Returns' 용어만을 판별하기 위해서 입니다. react.dev에서는 #(URI fragment)를 이용한 문서 navigation을 {/ ... /}을 통해 구현합니다.

Progress

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 11:02am

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hg-pyun hg-pyun merged commit 6bfce78 into reactjs:main Jul 25, 2024
5 checks passed
@lumirlumir lumirlumir deleted the feature-textlint branch July 25, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants