Skip to content

translate(sidebar-home): add missing title translations #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023

Conversation

oxcened
Copy link
Contributor

@oxcened oxcened commented May 1, 2023

Motivation

Generally on desktop you won't see it, but on a smaller viewport the homepage renders sidebarHome.json.
Currently it's missing the translations for Installation and Describing the UI pages, which are instead translated in sidebarLearn.json

We'll have to remember this for the future 😃

Current behaviour

@oxcened oxcened changed the title translate(sidebar-home): add missing title translation for installati… translate(sidebar-home): add missing title translations May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[[...markdownPath]] 77.92 KB (🟡 +7 B) 171.55 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@deblasis deblasis merged commit 79bfcda into reactjs:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants