Skip to content

v0.38.2 #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

v0.38.2 #758

wants to merge 12 commits into from

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jun 11, 2022

  • Fix idom.run failing to run if not specifying a server implementation.
  • Bump to 0.38.2
  • Disable greetings CI
  • Clean up references to idom.server
  • Fix one miscellaneous use of logger.warn (deprecated)
  • Fix typos in nox descriptions

@Archmonger Archmonger marked this pull request as ready for review June 11, 2022 23:58
@Archmonger Archmonger changed the title Fix IDOM run with default server v0.38.2 Jun 12, 2022
rmorshea
rmorshea previously approved these changes Jun 13, 2022
@rmorshea
Copy link
Collaborator

rmorshea commented Jun 13, 2022

I can't seem to figure out quite what's wrong with tests/test_web/test_module.py::test_module_from_url. It's failing when I run locally though too:
image

@Archmonger Archmonger marked this pull request as draft June 14, 2022 10:23
@Archmonger
Copy link
Contributor Author

Perhaps I did something wrong when bumping the version number?

I did it manually, since I couldn't recall if you had any scripts for it.

@rmorshea
Copy link
Collaborator

There is a script, but it bumps versions and pushes a tag at the same time. I guess I'd assumed that would be done by whoever is performing the release.

@Archmonger
Copy link
Contributor Author

@rmorshea Everything remaining seems to just be variable renaming... Not entirely sure how tests are failing.

@rmorshea
Copy link
Collaborator

BTW, I already merged a change that removes the greeting message in favor of a small PR template for now. Can revisit the greeting message later.

@rmorshea
Copy link
Collaborator

rmorshea commented Jun 16, 2022

I think I've got the fix here (there was one missing hasattr(self, "server") that needed to be renamed) + some other minor docstring changes: #763

Going to close this.

@rmorshea rmorshea closed this Jun 16, 2022
@Archmonger Archmonger deleted the fix-idom-run branch June 17, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants