Skip to content

use call_soon_threadsafe to add element updates to queue #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2020
Merged

use call_soon_threadsafe to add element updates to queue #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d37cdf
fixes: #222
rmorshea Sep 13, 2020
768fe5a
Merge branch 'master' into threadsafe
rmorshea Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions idom/core/layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,17 +268,18 @@ def __repr__(self) -> str:

class _ElementQueue:

__slots__ = "_queue", "_pending"
__slots__ = "_loop", "_queue", "_pending"

def __init__(self) -> None:
self._loop = asyncio.get_event_loop()
self._queue: "asyncio.Queue[AbstractElement]" = asyncio.Queue()
self._pending: Set[int] = set()

def put(self, element: AbstractElement) -> None:
element_id = id(element)
if element_id not in self._pending:
self._pending.add(element_id)
self._queue.put_nowait(element)
self._loop.call_soon_threadsafe(self._queue.put_nowait, element)
return None

async def get(self) -> AbstractElement:
Expand Down