Skip to content

Victory Chart must be unmounted before each render #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmorshea opened this issue Aug 11, 2021 · 2 comments
Closed

Victory Chart must be unmounted before each render #461

rmorshea opened this issue Aug 11, 2021 · 2 comments
Labels
priority-3-low May be resolved one any timeline.

Comments

@rmorshea
Copy link
Collaborator

I have no idea why this is. Other packages like Material UI seem to handle this fine, but Victory doesn't. According to the React docs, calling ReactDOM.render on the same node should work just fine, but for whatever reason, in this case it doesn't.
rmorshea added a commit that referenced this issue Aug 11, 2021
@rmorshea
add option to unmountBeforeUpdate
edcb6b7 
this is less than ideal - as such #461 has been created
in order to try and track down what the problem is. in
short victory charts do not update unless explicitely
unmounted before updating. ReactDOM.render should work
as expected, but for whatever reason it is not here.
rmorshea added a commit that referenced this issue Aug 12, 2021
@rmorshea
add option to unmountBeforeUpdate
3085db7 
this is less than ideal - as such #461 has been created
in order to try and track down what the problem is. in
short victory charts do not update unless explicitely
unmounted before updating. ReactDOM.render should work
as expected, but for whatever reason it is not here.
@rmorshea rmorshea added the bug label Jan 9, 2022
@rmorshea
Copy link
Collaborator Author

rmorshea commented Jan 9, 2022

This is probably a bug in Victory, we just need to confirm this.

@rmorshea rmorshea modified the milestones: 2.0, Future Jan 11, 2022
@rmorshea rmorshea added the priority-3-low May be resolved one any timeline. label Jan 13, 2022
@Archmonger Archmonger modified the milestones: Luxury, Essential Jan 29, 2023
@rmorshea rmorshea removed this from the Essential milestone Feb 21, 2023
@Archmonger
Copy link
Contributor

Closing since this issue is now obsolete

@Archmonger Archmonger closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-3-low May be resolved one any timeline.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmorshea @Archmonger