Skip to content

put_nowait is not threadsafe #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rmorshea opened this issue Sep 13, 2020 · 0 comments · Fixed by #224
Closed

put_nowait is not threadsafe #222

rmorshea opened this issue Sep 13, 2020 · 0 comments · Fixed by #224
Assignees
@rmorshea

Comments

@rmorshea
Copy link
Collaborator

In idom.Layout we use asyncio.Queue.put_nowait as if it were threadsafe. However we need to use loop.call_soon_threadsafe instead.
@rmorshea rmorshea added the bug label Sep 13, 2020
@rmorshea rmorshea self-assigned this Sep 13, 2020
rmorshea added a commit that referenced this issue Sep 13, 2020
@rmorshea
fixes: #222
0d37cdf
@rmorshea rmorshea mentioned this issue Sep 13, 2020
Merged
rmorshea added a commit that referenced this issue Sep 13, 2020
@rmorshea
fixes: #222
7236f20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmorshea rmorshea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use call_soon_threadsafe to add element updates to queue reactive-python/reactpy
1 participant
@rmorshea