Skip to content

20200517 release #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 17, 2020
Merged

20200517 release #1378

merged 10 commits into from
May 17, 2020

Conversation

AllenFang
Copy link
Member

No description provided.

AllenFang and others added 10 commits April 18, 2020 13:37
Doing the same operation of comparator might be more straightforward and
we don't need to declare a `valid` variable.
Refactor a little for filter.js in react-bootstrap-table2-filter
I added more info to the descriptions of the keyField and data props of
the Table component. I also added an example of what these properties
might look like for a sample dataset.

I had trouble figuring these out, and had to find a medium post about
this library to understand how the input data should be formatted, and I
had to read the source code to understand what the keyField was for. I
think having better descriptions of these props will be helpful to
users.
@AllenFang AllenFang merged commit 4d5787a into master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants