rcsofttech85 · rcsofttech85 · Sep 18, 2023 · Sep 18, 2023
diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,6 @@
+parameters:
+	level: 7
+	checkGenericClassInNonGenericObjectType: false
+	paths:
+		- src
+		- tests
diff --git a/src/CsvFileHandler.php b/src/CsvFileHandler.php
@@ -12,6 +12,14 @@ public function __construct(
     ) {
     }
 
+    /**
+     * @param string $filename
+     * @param string $keyword
+     * @param string $column
+     * @param string|null $format
+     * @return bool|array<string,string>
+     * @throws FileHandlerException
+     */
     public function searchInCsvFile(
         string $filename,
         string $keyword,
@@ -32,13 +40,18 @@ public function searchInCsvFile(
     }
 
 
-    public function toJson(string $filename): string
+    public function toJson(string $filename): string|false
     {
         $data = $this->toArray($filename);
 
         return json_encode($data);
     }
 
+    /**
+     * @param string $filename
+     * @return array<int,array<string,string>>
+     * @throws FileHandlerException
+     */
     public function toArray(string $filename): array
     {
         if (!file_exists($filename)) {
@@ -61,6 +74,9 @@ public function findAndReplaceInCsv(
         }
 
         $tempFilePath = $this->tempFileHandler->createTempFileWithHeaders($headers);
+        if (!$tempFilePath) {
+            return false;
+        }
 
 
         try {
@@ -86,22 +102,24 @@ public function findAndReplaceInCsv(
         return true;
     }
 
+    /**
+     * @param mixed $file
+     * @return array<string>|false
+     */
+
     private function extractHeader(mixed $file): array|false
     {
         $headers = [];
         if (is_resource($file)) {
             $headers = fgetcsv($file);
         }
         if (is_string($file)) {
-            if (!file_exists($file)) {
+            $file = fopen($file, 'r');
+            if (!$file) {
                 return false;
             }
-            try {
-                $file = fopen($file, 'r');
-                $headers = fgetcsv($file);
-            } finally {
-                fclose($file);
-            }
+            $headers = fgetcsv($file);
+            fclose($file);
         }
 
         if (!$headers) {
@@ -116,6 +134,10 @@ private function extractHeader(mixed $file): array|false
         return $headers;
     }
 
+    /**
+     * @param array<string> $row
+     * @return bool
+     */
     private function isValidCsvFileFormat(array $row): bool
     {
         if (count($row) <= 1) {
@@ -124,10 +146,21 @@ private function isValidCsvFileFormat(array $row): bool
         return true;
     }
 
+    /**
+     * @param string $filename
+     * @return Generator
+     * @throws FileHandlerException
+     */
     private function getRows(string $filename): Generator
     {
         $csvFile = fopen($filename, 'r');
+        if (!$csvFile) {
+            throw new FileHandlerException('file not found');
+        }
         $headers = $this->extractHeader($csvFile);
+        if (!is_array($headers)) {
+            throw new FileHandlerException('could not extract header');
+        }
 
 
         $isEmptyFile = true;
@@ -151,6 +184,12 @@ private function getRows(string $filename): Generator
         }
     }
 
+    /**
+     * @param array<string> $row
+     * @param string $keyword
+     * @param string $replace
+     * @return int
+     */
     private function replaceKeywordInRow(array &$row, string $keyword, string $replace): int
     {
         $count = 0;
@@ -164,6 +203,13 @@ private function replaceKeywordInRow(array &$row, string $keyword, string $repla
         return $count;
     }
 
+    /**
+     * @param array<string> $row
+     * @param string $column
+     * @param string $keyword
+     * @param string $replace
+     * @return int
+     */
     private function replaceKeywordInColumn(array &$row, string $column, string $keyword, string $replace): int
     {
         $count = 0;

diff --git a/src/FileEncryptor.php b/src/FileEncryptor.php
@@ -47,6 +47,9 @@ public function encryptFile(): bool
         $output = bin2hex($nonce . $ciphertext);
 
         $file = fopen($this->filename, 'w');
+        if (!$file) {
+            return false;
+        }
 
         try {
             fwrite($file, $output);
@@ -76,6 +79,9 @@ public function decryptFile(): bool
         }
 
         $bytes = hex2bin($encryptedData);
+        if (!$bytes) {
+            return false;
+        }
         $nonce = substr($bytes, 0, SODIUM_CRYPTO_SECRETBOX_NONCEBYTES);
         $ciphertext = substr($bytes, SODIUM_CRYPTO_SECRETBOX_NONCEBYTES);
 
@@ -89,6 +95,9 @@ public function decryptFile(): bool
 
 
         $file = fopen($this->filename, 'w');
+        if (!$file) {
+            return false;
+        }
 
         try {
             fwrite($file, $plaintext);

diff --git a/src/FileHandler.php b/src/FileHandler.php
@@ -10,17 +10,17 @@ class FileHandler
 {
     public const ARRAY_FORMAT = 'array';
 
+    /**
+     * @var array<resource>|null
+     */
     private null|array $files = [];
 
 
-    /**
-     * @throws FileHandlerException
-     */
     public function open(
         string $filename,
         string $mode = "w",
         bool $include_path = false,
-        $context = null
+        mixed $context = null
     ): self {
         $file = fopen($filename, $mode, $include_path, $context);
 
@@ -35,6 +35,9 @@ public function open(
 
 
     /**
+     * @param string $data
+     * @param int<0, max>|null $length
+     * @return void
      * @throws FileHandlerException
      */
     public function write(string $data, ?int $length = null): void
@@ -144,22 +147,4 @@ public function delete(string $filename): void
         }
         unlink($filename);
     }
-
-
-    public function getSingleFileProcessing(string|null $filename): mixed
-    {
-        if (empty($this->files)) {
-            if ($filename && file_exists($filename)) {
-                $this->open($filename);
-                return $this->files[0];
-            }
-            throw new FileHandlerException("No files to process or file not found: $filename");
-        }
-        if (count($this->files) > 1) {
-            throw new FileHandlerException("Multiple files not allowed");
-        }
-
-
-        return $this->files[0];
-    }
 }
diff --git a/src/FileHashChecker.php b/src/FileHashChecker.php
@@ -6,8 +6,8 @@
 
 class FileHashChecker
 {
-    const ALGO_256 = 'sha3-256';
-    const ALGO_512 = 'sha3-512';
+    public const ALGO_256 = 'sha3-256';
+    public const ALGO_512 = 'sha3-512';
 
     /**
      * @param string $filename
@@ -21,7 +21,6 @@ public function __construct(private readonly string $filename, private readonly
     }
 
     /**
-     * @param object $fileHandler
      * @param string $storedHashesFile
      * @param string $algo
      * @return bool
@@ -42,7 +41,7 @@ public function verifyHash(string $storedHashesFile, string $algo = self::ALGO_2
             format: FileHandler::ARRAY_FORMAT
         );
 
-        if (!$file) {
+        if (!$file || !is_array($file)) {
             throw new HashException('this file is not hashed');
         }
 

diff --git a/src/StreamHandler.php b/src/StreamHandler.php
@@ -8,10 +8,15 @@
 
 class StreamHandler
 {
+    /**
+     * @var array<Fiber> $fibers
+     */
     private array $fibers = [];
 
 
     /**
+     * @param array<string,string> $streamUrls
+     * @param int<0,100> $chunk
      * @throws StreamException
      */
     public function __construct(public readonly array $streamUrls, public readonly int $chunk = 100)
@@ -21,23 +26,27 @@ public function __construct(public readonly array $streamUrls, public readonly i
         }
     }
 
-    /**
-     */
+
     private function stream(string $streamUrl, string $outputFilename): Fiber
     {
         return new Fiber(function () use ($streamUrl, $outputFilename) {
             $stream = fopen($streamUrl, 'r');
-            if (!$stream) {
+            $outputFile = fopen($outputFilename, 'w');
+            if (!$stream || !$outputFile) {
                 throw new StreamException("Failed to open stream: $streamUrl");
             }
+
             stream_set_blocking($stream, false);
 
-            $outputFile = fopen($outputFilename, 'w');
 
             try {
                 while (!feof($stream)) {
-                    $contents = fread($stream, $this->chunk);
-                    fwrite($outputFile, $contents);
+                    $length = $this->chunk;
+                    $contents = fread($stream, $length);
+                    if ($contents) {
+                        fwrite($outputFile, $contents);
+                    }
+
                     Fiber::suspend();
                 }
             } catch (Throwable $e) {

diff --git a/src/TempFileHandler.php b/src/TempFileHandler.php
@@ -20,19 +20,36 @@ public function cleanupTempFile(string $tempFilePath): void
         }
     }
 
+    /**
+     * @param string $tempFilePath
+     * @param array<string> $row
+     * @return void
+     */
     public function writeRowToTempFile(string $tempFilePath, array $row): void
     {
         $tempFileHandle = fopen($tempFilePath, 'a');
-        fputs($tempFileHandle, implode(',', $row) . PHP_EOL);
-        fclose($tempFileHandle);
+        if ($tempFileHandle) {
+            fputs($tempFileHandle, implode(',', $row) . PHP_EOL);
+            fclose($tempFileHandle);
+        }
     }
 
-    public function createTempFileWithHeaders(array $headers): string
+    /**
+     * @param array<string> $headers
+     * @return string
+     */
+    public function createTempFileWithHeaders(array $headers): string|false
     {
         $tempFilePath = tempnam(sys_get_temp_dir(), 'tempfile_');
+        if (!$tempFilePath) {
+            return false;
+        }
         $tempFileHandle = fopen($tempFilePath, 'w');
-        fputs($tempFileHandle, implode(',', $headers) . PHP_EOL);
-        fclose($tempFileHandle);
+        if ($tempFileHandle) {
+            fputs($tempFileHandle, implode(',', $headers) . PHP_EOL);
+            fclose($tempFileHandle);
+        }
+
 
         return $tempFilePath;
     }

diff --git a/tests/Base/BaseTest.php b/tests/Base/BaseTest.php
@@ -9,9 +9,12 @@
 
 class BaseTest extends TestCase
 {
+    /**
+     * @var array<string>|null
+     */
     protected static array|null $files = [];
 
-    protected static ContainerBuilder|null $containerBuilder;
+    private static ContainerBuilder|null $containerBuilder;
 
     public static function setUpBeforeClass(): void
     {
@@ -38,4 +41,22 @@ public static function tearDownAfterClass(): void
         }
         static::$files = null;
     }
+
+    protected function isFileValid(string $filename): mixed
+    {
+        if (!file_exists($filename) || !$data = file_get_contents($filename)) {
+            $this->fail('file does not exists or has no content');
+        }
+        return $data;
+    }
+
+    protected function setObjectHandler(string $classname, string $serviceId): mixed
+    {
+        $objectHandler = self::$containerBuilder->get($serviceId);
+
+        if (!is_a($objectHandler, $classname)) {
+            $this->fail("provided service is not an instance of " . $classname);
+        }
+        return $objectHandler;
+    }
 }