-
Notifications
You must be signed in to change notification settings - Fork 189
Introduce proper v4 support for new apps #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tailwind v4 doesn't need a config file.
e614cdf
to
6c33f3d
Compare
@flavorjones wow, so fast! There is still something missing though, renaming the generator class names to suport the newer ones that were renamed, as my commit fd342bc for reference: https://tailwindcss.com/docs/upgrade-guide#renamed-utilities |
Note: we will need to smooth this out in an upgrade step.
6c33f3d
to
144eaa7
Compare
Edited this PR to remove the injected compatibility styles. I'll make that part of the upgrade generator in a separate PR. |
@EricGusmao Thanks for the commit updating class names, I've cherry-picked that into this PR. |
so the idea is to create a upgrade generator to patch current installations? |
Yes, I've got one ready to create a PR with that's pretty simple -- does minimal patching and then runs the upstream upgrader. @EricGusmao Do you agree this PR is OK to merge? Can you think of anything missing for the "tailwindcss:install" use case in a new app? |
I think this is a good improvement, so I'm going to merge it. We can continue to fix things as we find them. |
Yes, lgtm |
Main changes to the installer:
~> 4.0
config.tailwind.js
file, and the-c
option from the tailwindcss commandimport "tailwindcss";
toapplication.tailwind.css
Note that this PR also removes the Inter font, which may leave an orphaned stylesheet reference in existing apps that upgrade:
This will need to be replaced/fixed by an upgrade generator/task, but I don't think it needs to be part of this PR right now.
cc @EricGusmao for feedback
Closes #463