Skip to content

feat: allow overriding executable with environment variable #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

piperswe
Copy link

This allows users to provide a path to their own tailwindcss executable, which can be handy in cases where the pre-built ones won't work (e.g. in bundix-based Nix setups).

Closes #224
Replaces/closes #226

@piperswe piperswe force-pushed the allow_env_exe_override branch 4 times, most recently from 17db613 to 61a5d0b Compare March 30, 2023 01:31
@piperswe piperswe force-pushed the allow_env_exe_override branch from 61a5d0b to d6b4d55 Compare March 30, 2023 01:34
@flavorjones
Copy link
Member

Hi, @piperswe, thanks for the PR. I'm not sure the testing coverage here is thorough enough -- see #226 for some examples of the kinds of tests that I think are necessary when we're trying to ensure the native binaries will work correctly.

I may end up just updating #226 with the env var approach as I mentioned there ... though if you want to take a stab at increasing the test coverage here I'd be happy to give more explicit feedback.

Either way, I appreciate the nudge, and I will try to ship something this weekend.

@nanaya
Copy link

nanaya commented Mar 30, 2023

Platform check needs to be skipped when env is specified otherwise it doesn't help people running on unsupported platforms but do have nodejs which can run tailwindcss.

@flavorjones
Copy link
Member

@piperswe Thanks again for the PR and for nudging me on this. I've updated #226 with a similar approach to what you've done here, but with a bit more test coverage for a few different edge cases. I'm going to close this in preference to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pointing to the tailwindcss executable
3 participants