-
Notifications
You must be signed in to change notification settings - Fork 189
allow users to always generate unminified CSS #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3bd82c4
to
758471e
Compare
758471e
to
6425cb7
Compare
end | ||
|
||
def truthy_string_value(value) | ||
if !value.present? || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have present?
available? The core_ext is not being required in this gem. I think it only works in tests because the app is configured to require all core_ext.
I don't see the point? I see the request, but not the purpose. |
@the-pulli Can you explain your use case a bit more, please? |
@flavorjones Sure thing. I have a project which uses TW and custom CSS. If I don't use yui as CSS compressor only my TW CSS gets minified and my custom CSS not. If I use yui as compressor TW gets again minified through yui and it get messed up. My custom CSS gets minified normally in this procedure. I was looking for a way to minify both TW and my custom CSS for production. |
I think this should be fixed elsewhere rather than in TW. The minifier should be able to opt out of being applied to a given CSS. Rather than TW knowing about not having to minify. |
@dhh So if I understood you right, there is currently no way to do this in Rails? It has to be implemented (preferable the code handling compression of the files), but not in TW? |
Discussed in #243.
Closes #244.
This PR allows users to set an environment variable
TAILWINDCSS_RAILS_NO_MINIFY
to turn off minification.