Skip to content

Make sure qos, heartbeat, max channel are unsigned shorts #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acogoluegnes opened this issue Apr 2, 2020 · 1 comment
Closed

Make sure qos, heartbeat, max channel are unsigned shorts #642

acogoluegnes opened this issue Apr 2, 2020 · 1 comment
Assignees
@acogoluegnes
Labels
bug usability
Milestone
5.9.0

Comments

@acogoluegnes
Copy link
Contributor

#640 makes sure qos/heartbeat/max channel are always unsigned, failing they are not. This is a breaking change though, a less drastic solution is required for 5.x and 4.x. An acceptable solution consists in setting the value to 0 or 65535 if it's out of range and issuing a warning.
@acogoluegnes acogoluegnes self-assigned this Apr 2, 2020
@acogoluegnes acogoluegnes added this to the 5.8.1 milestone Apr 2, 2020
acogoluegnes added a commit that referenced this issue Apr 2, 2020
@acogoluegnes
Make sure qos, heartbeat, max channel are unsigned shorts
f2ea862 
Sets the value to 0 or 65535 and issues a warning if it is out of range.

Fixes #642
@acogoluegnes acogoluegnes mentioned this issue Apr 2, 2020
Merged
@acogoluegnes acogoluegnes modified the milestones: 5.8.1, 5.9.0 Apr 3, 2020
@acogoluegnes
Copy link
Contributor Author

Fixed in #643.

acogoluegnes added a commit that referenced this issue Apr 3, 2020
@acogoluegnes
Make sure qos, heartbeat, max channel are unsigned shorts
f6f89f6 
Sets the value to 0 or 65535 and issues a warning if it is out of range.

Fixes #642

(cherry picked from commit f2ea862)

Conflicts:
	src/main/java/com/rabbitmq/client/ConnectionFactory.java
acogoluegnes added a commit that referenced this issue Feb 22, 2021
@acogoluegnes
Fix AMQP parsing test
bf362d5 
Difference between 6.x and 5.x.

References #640, #642, #672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
bug usability
Projects
None yet
Milestone
5.9.0
Development

No branches or pull requests
1 participant
@acogoluegnes