Resolves #1519

[krammnic]

torchtune now can be an optional dependency. In most of the cases, the import was just moved to a specific function or class. In the case of the openai_api.py, the better solution was to just remove the unused import and Message type hint, because it is not a real reason to have an import of an optional library in the class.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1539

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Cancelled Jobs

As of commit 8b9d9df with merge base 0299a37 ():

NEW FAILURES - The following jobs have failed:

• pull / runner-et (16-core-ubuntu) (gh)
  Process completed with exit code 1.
• pull / test-build-runner-et-android / linux-job (gh)
  RuntimeError: Command docker exec -t 8fbf54831e141ec0d3ceb6d6cd355cb59d29a5cf116a7dd7f684fc321394169d /exec failed with exit code 1
• pull / test-tinystories-executorch (16-core-ubuntu) (gh)
  Process completed with exit code 1.
• pull / test-torchao-experimental-et (macos-14-xlarge) (gh)
  Process completed with exit code 1.

CANCELLED JOBS - The following jobs were cancelled. Please retry:

• pull / runner-et (macos-14-xlarge) (gh)
  ##[error]The operation was canceled.
• pull / test-tinystories-executorch (macos-14-xlarge) (gh)
  ##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[krammnic]

Oops, it seems to me that there are some problems with linting... I've ran it according to the CONTRIBUTING.md but it seems to me that there are some wrong instructions. Furthermore, I don't see CI linting job.

[Jack-Khuu]

Thanks for the PR, just kicked off the CI

hmm we'll take a gander at the linter (not blocking this pr on lint)

[Jack-Khuu]

Thanks for the initial pass
I think we'll need to be a tad more aggressive with pushing the imports deeper into conditionals to avoid hitting the torchtune import calls prematurely

(lint changes are also looking good)

[Jack-Khuu]

You can ignore the failing et/executorch CI, that's a separate issue

[krammnic]

Thanks for the initial pass I think we'll need to be a tad more aggressive with pushing the imports deeper into conditionals to avoid hitting the torchtune import calls prematurely

(lint changes are also looking good)

Thanks for the review! Sure, let's put them deeper then.

[krammnic]

@Jack-Khuu Hey! Fixed according to your comments. Moved imports deeper in cases when it was reasonable