Skip to content

Use torch.accelerator in DCGAN example #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

dggaytan
Copy link
Contributor

Refactor DCGAN examples to utilize torch.accelerator API torch.accelerator API allows to abstract some of the accelerator specifics in the user scripts. By leveraging this API, the code becomes more adaptable to various hardware accelerators.

  • Updated dcgan/main.py with accelerator flag
  • Updated README to match dcgan/main.py
  • Updated requirements, removed pinned torchvision version
  • Updated run_python_examples.sh to match new accelerator flag

CC: @msaroufim, @malfet, @dvrogozh

@dggaytan dggaytan requested a review from msaroufim as a code owner May 12, 2025 17:59
Copy link

netlify bot commented May 12, 2025

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit c4c6934
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/6822773d5c8a6400084c6ea6

@facebook-github-bot
Copy link
Contributor

Hi @dggaytan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@dggaytan dggaytan force-pushed the dggaytan/dcgan_accel branch from 327e2ca to 2b37d44 Compare May 12, 2025 22:30
@dggaytan dggaytan force-pushed the dggaytan/dcgan_accel branch from 2b37d44 to c4c6934 Compare May 12, 2025 22:33
@dggaytan dggaytan requested a review from dvrogozh May 12, 2025 22:34
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[--netD NETD] [--mps]

optional arguments:
usage: main.py [-h] --dataset DATASET [--dataroot DATAROOT]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify some of the changes: you updated the readme with the actual output from main,py --help, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @msaroufim, can you, please, help to take a look and merge if all is ok?

@msaroufim msaroufim merged commit cc8e404 into pytorch:main May 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants