Add macOS wheels and simplify release process #267
Conversation
jborean93
force-pushed
the
macOS-wheel
branch
3 times, most recently
from
8f2654d to
fe405b5
Compare
Converts the existing GitHub action files to YAML to reduce some of the quotes, lines, and support comments. Changes the release process to build the sdist first and then the wheels are built from that sdist. Also adds macOS wheels to the publishing process. Signed-off-by: Jordan Borean <[email protected]>
|
The wheels and sdist to test from this release process. Will need to manually verify this still works on Windows and macOS before merging this PR. The artifact is from https://github.com/pythongssapi/python-gssapi/pull/267/checks?check_run_id=3811298187 which essentially ran the |
|
@aiudirog if you get a chance it would be great if you could validate some of the Windows wheels in artifact.zip. This PR changes the build process to use cibuildwheel and while I don't forsee any problems with the changes it would be nice to have that validated by someone who uses the library. I've done a comparison on some of the |
|
I've manually tested the I feel confident the macOS wheels here will be fine going forward. |
|
This looks great! Can we do an RC release (either 1.8.0rc1 or 1.7.1rc1, not sure where we are semver speaking) so the wheels get built this way and uploaded to PyPI but not set as the default for the public yet? Then I can run some tests on them exactly as they will be built. |
|
That's a good idea, I'll probably settle on |
This changes the github workflows to an actual yaml definition (my personal preference over the quoting hell that is json).
This now uses cibuildwheel to build the Windows and macOS wheels instead of it being a manual step. The release process on PyPI is now one step instead of the manual twine call.
Fixes #230
Signed-off-by: Jordan Borean [email protected]