-
Notifications
You must be signed in to change notification settings - Fork 49
Enable specification of krb5-config via environment variable #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build look good with py36, py37, py38 (default), and py39 on FreeBSD 12.2-RELEASE amd64 against: |
Signed-off-by: John W. O'Brien <[email protected]>
Hmm, okay. I think I had a perhaps more invasive change in mind. Right now we've got
Since I'm being fussy here, please let me know if you'd rather I make those changes :) |
Unless I'm missing something, it already works this way. More to the point, the FBSD logic only affects
Makes complete sense to me. That's a little more than I think I can sign up to at the moment, though.
Now I really feel like I'm missing something. |
Hmm, you're right - I managed to confuse myself somewhere in there. We merely set krb5-config, but don't actually invoke it. So this should be fine then. |
@jborean93 Before I merge, are you okay with the new variable name? |
My apologies @frozencemetery just saw this, the new name is fine with me (although it's already merged :)). |
Closes #250