Skip to content

Fix tests to run wth current setups #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2020

Conversation

frozencemetery
Copy link
Member

@frozencemetery frozencemetery commented Nov 12, 2020

This supersedes #219, which I've updated, and fixes #220 and #215.

@frozencemetery frozencemetery force-pushed the s4u2fix branch 5 times, most recently from 8b7664e to 2357ea8 Compare November 13, 2020 17:16
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Take the comments or leave them, there's more than I cared to point out, probably easier to find in an editor. Ran the test locally, work for me. :)

stanislavlevin and others added 4 commits November 13, 2020 15:17
Fixes: pythongssapi#215
Merges: pythongssapi#219

Signed-off-by: Stanislav Levin <[email protected]>
Signed-off-by: Robbie Harwood <[email protected]>

[[email protected]: bugfixes, rebase around six changes, not abusing
Python equating empty and False, misc additional test cleanups, commit
message]
These tests relied on rickety behavior and caching.  Redo them to
actually test impersonation.  Fixes problems with krb5 >= 1.18.2.

Resolves: pythongssapi#220

Signed-off-by: Robbie Harwood <[email protected]>
This reverts 274886c.

Signed-off-by: Robbie Harwood <[email protected]>
Our venerable hack of setting the hostname on the host doesn't seem to
work on newer Fedora.

Signed-off-by: Robbie Harwood <[email protected]>
@frozencemetery frozencemetery merged commit 93ce057 into pythongssapi:main Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-tests fail againt krb5 1.18.2
3 participants