Removed six package and other older py cleanup values #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.txt
Outdated
| @@ -38,7 +38,7 @@ Basic | |||
|
|
|||
| * Python 3.6+ (older releases support older versions, but are unsupported) | |||
|
|
|||
| * the `six` and `decorator` python packages | |||
| * the `decorator` python packages | |||
| @@ -4,7 +4,7 @@ | |||
| # and then run "tox" from this directory. | |||
|
|
|||
| [tox] | |||
| envlist = py27,py33,py34,py35,py36,py37 | |||
| envlist = py36,py37,py38 | |||
There was a problem hiding this comment.
python-3.8 won't work yet; we need to figure out and merge #219 for that. This PR will cause a merge conflict with that one, but it should be easily sorted once this merges. Since we don't use tox ourselves, this is probably fine.
gssapi/_utils.py
Outdated
| return x.encode(_ENCODING) | ||
| else: | ||
| return x | ||
|
|
||
| return dict((enc(k), enc(v)) for k, v in six.iteritems(d)) | ||
| return dict((enc(k), enc(v)) for k, v in iter(d.items())) |
There was a problem hiding this comment.
This can be more clear with a dict comprehension.
Resolves: pythongssapi#221 [[email protected]: cleaned up a couple idioms]
frozencemetery
force-pushed
the
remove-six
branch
from
371c7ee to
dac08a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Six was only required when the code was trying to be py2 compatible. That's no longer the case so we can remove that requirement.
Fixes #221