Hopefully fix test issues around high-level mechanism support and indicate/inquire mechs. #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate that sasl_name is nonempty before assigning it to base; this prevents the situation where the sasl_name query succeeds, but the contents of the name are empty. Signed-off-by: Alexander Scheel <[email protected]>
DirectXMan12
suggested changes
Oct 2, 2018
gssapi/tests/test_raw.py
Outdated
| attrs = set([last_attr]) | ||
| if mech_attr not in attrs_dict: | ||
| attrs_dict[mech_attr] = 0 | ||
| attrs_dict[mech_attr] += 1 |
There was a problem hiding this comment.
the comment above needs to reflect the commit message comments to explain what's going on here.
Also, don't you need to ensure that last_mech actually has the attr -- maybe we should record the mechs that have each attr?
|
Also, please give a better PR title ;-) |
In particular, sasl names and descriptions can be empty for some mechanisms (NTLM in particular); do not fail the test suite because they are empty. Signed-off-by: Alexander Scheel <[email protected]>
While this can still fail, less likely to fail than querying on the last-seen attr. In particular, some mechanisms will not respond to an inquiry for that attr despite claiming to have it. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
changed the title
DirectXMan12
approved these changes
Oct 3, 2018
|
Looks reasonable to me. @frozencemetery can you take a gander, then we can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues found by the NTLM mechs:
Hopefully these behave a little better. :)