-
Notifications
You must be signed in to change notification settings - Fork 49
Add documentation for cred store common values #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good, but couple of comments inline
docs/source/credstore.rst
Outdated
Common Values for Credentials Store Extensions | ||
============================================== | ||
|
||
.. py:module:: gssapi.raw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't the gssapi.raw
module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is it ?
sphinx complains if there is no module
docs/source/index.rst
Outdated
@@ -28,6 +28,7 @@ straight into the :doc:`high-level API documentation <gssapi>`. | |||
|
|||
gssapi.rst | |||
gssapi.raw.rst | |||
credstore.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add an extra level of indirection in the ToC, like we do for tutorials. So maybe Implementation-Specific Tips and Documentation
, and then list the Cred Store stuff under that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
docs/source/credstore.rst
Outdated
:func:`gssapi.raw.ext_cred_store.add_cred_from` functions, to indicate a | ||
custom location for a keytab containing client keys. | ||
It is not used in the context of calls used to store credentials. | ||
The value is a string in the form "type:residual" where type can be any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the word residual
is a bit unclear here. Maybe something like
type:config
, where config is some type-specific configuration. For instance, for theFILE
type,config
is a path, likeFILE:/tmp/my.keytab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
residual is the technical name as found in MIT docs, at most I can use "path" if you think residual is to be avoided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe put in in parens or something. It's non-obvious to most people that haven't already read the MIT docs, but it's good to have it there for people who have.
@DirectXMan12 PTAL |
@DirectXMan12 ping ? |
responded to the |
d6f650b
to
8c682df
Compare
Signed-off-by: Simo Sorce <[email protected]>
Add docs to explain what cred store values can be used and how