-
Notifications
You must be signed in to change notification settings - Fork 49
gssapi.raw.inquire_attrs_for_mech may segfault #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
DirectXMan12
added a commit
that referenced
this issue
Mar 21, 2018
Some methods can return GSS_C_NO_OID_SET on success, so we should handle that in our set converter by returning the empty set. Fixes #148
frozencemetery
added a commit
that referenced
this issue
Mar 21, 2018
This lets us test that the NTLM mechanism behaves correctly and properly test #148.
frozencemetery
added a commit
that referenced
this issue
Mar 21, 2018
This lets us test that the NTLM mechanism behaves correctly and properly test #148.
frozencemetery
added a commit
that referenced
this issue
Mar 21, 2018
This lets us test that the NTLM mechanism behaves correctly and properly test #148.
frozencemetery
pushed a commit
that referenced
this issue
Mar 26, 2018
Some methods can return GSS_C_NO_OID_SET on success, so we should handle that in our set converter by returning the empty set. Fixes #148
frozencemetery
added a commit
that referenced
this issue
Mar 26, 2018
This lets us test that the NTLM mechanism behaves correctly and properly test #148.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using this function gss_inquire_attrs_for_mech() is called.
This function can legally return GSS_S_COMPLETE with GSS_NO_OID_SET for both return arguments.
However we do not catch this case and try to build sets for both causing a seggault as soon as we try to check for mech_set.count inside of c_create_oid_set()
You can test this with MIT (any version) and GSS-NTLMSSP and this snippet:
The text was updated successfully, but these errors were encountered: