Skip to content

Enable warn_unreachable = True for mypyc and all other files as well #19050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wyattscarpenter
Copy link
Contributor

Achieves a todo, enabling warn_unreachable = True for mypyc and all other files as well

@wyattscarpenter
Copy link
Contributor Author

wyattscarpenter commented May 8, 2025

I am now waiting on mypyc/mypyc#1101 to be resolved to finish this issue, after which I will have to rebase this branch onto master to get the resolution.

Copy link
Contributor

github-actions bot commented May 8, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sterliakov
Copy link
Collaborator

Wow, only one hit? That should be easy to resolve...

@wyattscarpenter
Copy link
Contributor Author

@stanislavlevin, yep! Only one hit for this project 🥳!Unfortunately (so to speak), deciding what to do about that is best left to people more familiar with mypyc than me.

I could simply comment out this code, which I might do eventually, but if someone with a better idea about what it should do comes along, I will defer to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants