Consider adding --strict-equality to --strict

[berquist]

This doesn't report any errors with --strict-equality:

def foo() -> bool:
    x: int = 5
    y: str = "foo"
    return x == y


def bar() -> bool:
    x = 5
    y = "bar"
    return x == y


def is_magic(x: bytes) -> bool:
    # Error: Non-overlapping equality check (left operand type: "bytes",
    #        right operand type: "str")  [comparison-overlap]
    return x == "magic"


if __name__ == "__main__":
    print(foo())
    print(bar())
    print(is_magic(b"magic"))

even though the third example is from the docs.

Versions:

• Python: 3.7.4
• mypy: 0.750+dev.59617e8f895ca12a6fb0ec46f378ce384a757118

[ilevkivskyi]

I don't know what you are doing, everything works perfectly for me. Maybe you have have a broken install, or something else.

[berquist]

I was using --strict, not --strict-equality.

[ilevkivskyi]

I was using --strict, not --strict-equality.

Hm, actually now that it is a bit more "mature" we can make it a strict flag, unless @msullivan is against.

See also #7469

[msullivan]

Fine by me.