Skip to content

Add missing test/input/func_model_does_not_use_unicode_py33.txt in the MANIFEST.in #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2018

Conversation

aerostitch
Copy link
Contributor

Hi,

Right now the file test/input/func_model_does_not_use_unicode_py33.txt is not present in the pypi distribution and as we switched the source to pypi when packaging for Debian, we end up with this error:

____________ test_everything[func_model_does_not_use_unicode_py33] _____________

test_file = <test_functional.FunctionalTestFile object at 0x7f2b78ec3438>

    @pytest.mark.parametrize("test_file", TESTS, ids=TESTS_NAMES)
    def test_everything(test_file):
        # copied from pylint.tests.test_functional.test_functional
        LintTest = PylintDjangoLintModuleTest(test_file)
        LintTest.setUp()
>       LintTest._runTest()

test/test_func.py:43:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/local/lib/python3.6/dist-packages/pylint/test/test_functional.py:308: in _runTest
    expected_messages, expected_text = self._get_expected()
/usr/local/lib/python3.6/dist-packages/pylint/test/test_functional.py:289: in _get_expected
    with self._open_expected_file() as fobj:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <test.test_func.PylintDjangoLintModuleTest object at 0x7f2b77f55f28>

    def _open_expected_file(self):
>       return open(self._test_file.expected_output)
E       FileNotFoundError: [Errno 2] No such file or directory: '/tmp/autopkgtest.FOBT3E/build.TBr/src/test/input/func_model_does_not_use_unicode_py33.txt'

/usr/local/lib/python3.6/dist-packages/pylint/test/test_functional.py:276: FileNotFoundError

This PR adds the missing text file in the MANIFEST.in.

Thanks for your help!
Joseph

@coveralls
Copy link

coveralls commented Feb 23, 2018

Pull Request Test Coverage Report for Build 281

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.826%

Files with Coverage Reduction New Missed Lines %
pylint_django/transforms/fields.py 1 98.11%
Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 464
Relevant Lines: 547

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 280

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 84.826%

Files with Coverage Reduction New Missed Lines %
pylint_django/transforms/fields.py 1 98.11%
Totals Coverage Status
Change from base Build 279: 0.0%
Covered Lines: 464
Relevant Lines: 547

💛 - Coveralls

@aerostitch
Copy link
Contributor Author

Also added the missing rc files from the test/input directory as them missing was causing other errors.

@atodorov atodorov merged commit 752b297 into pylint-dev:master Feb 24, 2018
@atodorov
Copy link
Contributor

@aerostitch thanks for the PR. Do you need us to release a new version on PyPI so you can pick it up for Debian packaging ?

@carlio
Copy link
Member

carlio commented Feb 24, 2018

@atodorov @aerostitch Is a git tag sufficient? That's how it works for requirements-detector but I was never involved in this so I have no idea! We can bump/release to PyPI or tag, whatever is best.

(tags for every release is a good idea anyway I would say)
(also versioning was never particularly semantic, the 0 at the beginning is because I never considered it finished, the second was to denote major changes, the last was just a counter to make pip etc pick up the latest bugfix release)

@aerostitch aerostitch deleted the fix_missing_txt_file branch February 25, 2018 05:59
@aerostitch
Copy link
Contributor Author

aerostitch commented Feb 25, 2018

@atodorov That would be great if we can cut a new pypi release with this, yes! :)
Given the commits since latest release I guess it will be 0.9.1.

@carlio Yes it's generally a good practice to release a tag for every release. But I know that at the beginning the releases didn't have a corresponding tag so I guess it's not automatic.
I guess you'll have to use the following to upload your package: https://packaging.python.org/tutorials/distributing-packages/#uploading-your-project-to-pypi (given of course that your pypi account has the right to do that for this package)

@atodorov
Copy link
Contributor

@aerostitch 0.9.1 is already on PyPI, let me know if there are problems with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants