Make EraseChip optional #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! I was simply too lazy to implement it, but also, I think we should encourage the addition of a total chip erase because in most cases it's what you want and it's much faster :) |
According to [1], only Init, UnInit, EraseSector, and ProgramPage are mandatory. [1]: https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/main/html/flashAlgorithm.html#FlashPrg
nilfit
force-pushed
the
optional-functions-as-features
branch
from
9e3978d to
0bbc407
Compare
|
That makes sense. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this document, only
Init,UnInit,EraseSector, andProgramPageare mandatory.Leaving the optional functions opt-in allows support for
VerifyandBlankCheckto be added later without breaking compatibility.