Add pg_probackup plugin #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demonolock
force-pushed
the
add-pg-probackup-plugin
branch
5 times, most recently
from
9bb5c24 to
03d8f96
Compare
demonolock
force-pushed
the
add-pg-probackup-plugin
branch
13 times, most recently
from
eda1a5b to
a868d71
Compare
asavchkov
reviewed
Dec 6, 2023
plugins/setup.py
Outdated
|
|
||
| setup( | ||
| version='0.0.1', | ||
| name='testgres-pg_probackup2', |
There was a problem hiding this comment.
This setup.py is in the plugins folder and thus relates to all plugins in the folder (of which there can be many) but it's now written specifically for pg_probackup2. Wouldn't it be better to have here one common setup.py to install all plugins at once and have individual setup.py's inside each plugin folder to allow the user to install them selectively?
demonolock
force-pushed
the
add-pg-probackup-plugin
branch
10 times, most recently
from
8040da5 to
4d45e02
Compare
demonolock
force-pushed
the
add-pg-probackup-plugin
branch
from
4d45e02 to
6c4095c
Compare
asavchkov
approved these changes
Dec 12, 2023
demonolock
force-pushed
the
add-pg-probackup-plugin
branch
3 times, most recently
from
58682c0 to
49628f0
Compare
demonolock
force-pushed
the
add-pg-probackup-plugin
branch
2 times, most recently
from
b25ea73 to
94b1061
Compare
demonolock
force-pushed
the
add-pg-probackup-plugin
branch
from
94b1061 to
a388f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.