-
Notifications
You must be signed in to change notification settings - Fork 35
Add promote() method #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c6e61b9
Add PostgresNode.promote() method which promotes standby node to master
zilder 06d1005
Add synchronous promotion support on pg of version < 10
zilder 5ea4bd8
Add PostgresNode.promote() method which promotes standby node to master
zilder 7c48fae
Add synchronous promotion support on pg of version < 10
zilder 838a800
fix promote() method for Postgres versions below 10
zilder 4f2b77d
Merge branch 'promote' of github.com:zilder/testgres into promote
zilder f5fe963
Use pg_is_in_recovery() instead of relying on transaction_read_only G…
zilder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -683,14 +683,50 @@ def reload(self, params=[]): | |
_params = [ | ||
get_bin_path("pg_ctl"), | ||
"-D", self.data_dir, | ||
"-w", # wait | ||
"reload" | ||
] + params # yapf: disable | ||
|
||
execute_utility(_params, self.utils_log_file) | ||
|
||
return self | ||
|
||
def promote(self, dbname=None, username=None): | ||
""" | ||
Promote standby instance to master using pg_ctl. For PostgreSQL versions | ||
below 10 some additional actions required to ensure that instance | ||
became writable and hence `dbname` and `username` parameters may be | ||
needed. | ||
|
||
Returns: | ||
This instance of :class:`.PostgresNode`. | ||
""" | ||
|
||
_params = [ | ||
get_bin_path("pg_ctl"), | ||
"-D", self.data_dir, | ||
"-w", # wait | ||
"promote" | ||
] # yapf: disable | ||
|
||
execute_utility(_params, self.utils_log_file) | ||
|
||
# for versions below 10 `promote` is asynchronous so we need to wait | ||
# until it actually becomes writable | ||
if self._pg_version < '10': | ||
check_query = "SHOW transaction_read_only" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not safe since transactions might be read-only by default. |
||
|
||
self.poll_query_until( | ||
query=check_query, | ||
expected="off", | ||
dbname=dbname, | ||
username=username, | ||
max_attempts=0) # infinite | ||
|
||
# node becomes master itself | ||
self._master = None | ||
|
||
return self | ||
|
||
def pg_ctl(self, params): | ||
""" | ||
Invoke pg_ctl with params. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!