Unique system ids for cached initdb #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 97.17% 97.17% -0.01%
==========================================
Files 13 13
Lines 1167 1202 +35
==========================================
+ Hits 1134 1168 +34
- Misses 33 34 +1
Continue to review full report at Codecov.
|
ildus
approved these changes
Feb 21, 2018
|
I've modified shardman to use this stuff and it works great, thanks. |
arssher
reviewed
Feb 24, 2018
| system_id |= (os.getpid() & 0xFFF) | ||
|
|
||
| # pack ULL in native byte order | ||
| return struct.pack('=Q', system_id) |
There was a problem hiding this comment.
This will probably bail out with struct.error: argument out of range after 19 January 2038, but for now it is fine :)
There was a problem hiding this comment.
@arssher Why? We have 32 bits for seconds, and that's ~136 years.
There was a problem hiding this comment.
Ah, =Q is unsigned. Yes, then we have 68 years more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If enabled, generate unique system ids for nodes spawned from initdb cache.