Skip to content

Catchup command implementation #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 73 commits into from
Jun 21, 2021
Merged
Show file tree
Hide file tree
Changes from 71 commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
51e20d9
fix forgotten in 29adb5b comment
kulaginm Feb 1, 2021
c4a8488
porting catchup to release_2_5 branch
kulaginm May 14, 2021
3d2bcda
Merge branch 'master' into release_2_5-pgpro-4850
gsmolk May 15, 2021
69db990
use correct args for wait_wal_lsn()
gsmolk May 15, 2021
6a3c3d3
[Issue #277] review, some improvements, refactoring and overhaul, sev…
gsmolk May 16, 2021
2afa159
[Issue #277] run catchup test in remote mode only if envvar PGPROBACK…
gsmolk May 16, 2021
2f843a7
[Issue #227] Remove support of ptrack1.x, clean up redundant code in …
gsmolk May 16, 2021
2f8617d
cosmetic changes
kulaginm May 18, 2021
61f167c
rename pg_checksum_enable() to pg_is_checksum_enabled
kulaginm May 18, 2021
30543b2
remove unused instanceState from pg_start_backup()
kulaginm May 24, 2021
1657fee
Refactor wait_wal_lsn(): remove unused pgBackup * parameter and repla…
kulaginm May 24, 2021
fffa8b1
Refactor pg_stop_backup(): remove useless conn variable
kulaginm May 24, 2021
ed5d71e
Make some functions and variables (from backup.c) accessible from oth…
kulaginm May 24, 2021
f7196e8
Remove some references to global stream_wal variable
kulaginm May 24, 2021
bd9cd9f
remove unused variable externaldir
kulaginm May 24, 2021
1793c68
Yet another split of pg_stop_backup(): separate verification of stop_…
kulaginm May 24, 2021
a13a23f
Merge branch 'release_2_5-pgpro-5018' into release_2_5-pgpro-4850
kulaginm May 24, 2021
7415e6c
Merge branch 'release_2_5-pg_stop_backup-decomposition2' into release…
kulaginm May 24, 2021
02aa321
catchup update #1
kulaginm May 24, 2021
24bd657
make separate function for node creation in catchup tests (make_empty…
kulaginm May 24, 2021
eab58c1
simple delta catchup test
kulaginm May 24, 2021
9efea2b
Remove get_min_recovery_point() and use get_redo() instead
kulaginm May 24, 2021
1c1a89c
catchup update #2
kulaginm May 25, 2021
d7e2606
catchup update #3 (tablespace mapping fix)
kulaginm May 25, 2021
2c8b7e9
create pfilearray_clear_locks() helper function
kulaginm May 26, 2021
bbacdf0
Merge remote-tracking branch 'origin/release_2_5-pg_stop_backup-decom…
kulaginm May 26, 2021
50cd84d
followup for 02aa32107433c34f6f7f264585e051cc7b5dbab1
kulaginm May 26, 2021
bc2f392
catchup update #4 (fix removed files)
kulaginm May 26, 2021
55ee681
Merge remote-tracking branch 'origin/release_2_5' into release_2_5-pg…
kulaginm May 27, 2021
05c451e
test stabilization
kulaginm May 27, 2021
fd7571b
test_tablefile_truncation added
kulaginm May 27, 2021
72b5bba
Improve catchup help
kulaginm May 28, 2021
bee476c
pg_control now is synced last
kulaginm May 31, 2021
74cd21a
apply lubennikovaav review.patch
kulaginm May 31, 2021
271cf16
indent correction as noted by Roman Zharkov
kulaginm May 31, 2021
8e03b8d
Review answer #1
kulaginm May 31, 2021
b294557
typo
kulaginm Jun 1, 2021
2e3adf1
check emptyness of dest_pgdata
kulaginm Jun 1, 2021
861ddd3
check that user uses tablespace_mapping
kulaginm Jun 1, 2021
e865c83
fix destination file existance
kulaginm Jun 2, 2021
2598c99
Print octal permissions in tests compare_pgdata()
kulaginm Jun 2, 2021
746a1a5
fix local delta backup
kulaginm Jun 2, 2021
2cceb71
Review answer #2
kulaginm Jun 2, 2021
803a7e3
add more catchup preflight checks
kulaginm Jun 3, 2021
5b46f09
rename cmdline parameters, remove annoyng message
kulaginm Jun 3, 2021
18c4b46
one more review pass
lubennikovaav Jun 7, 2021
19ace74
Merge remote-tracking branch 'origin/release_2_5' into release_2_5-pg…
kulaginm Jun 7, 2021
01fe2f9
Additional tablespace checks
kulaginm Jun 7, 2021
39df7ac
[DOC] Added documentation for catchup command
indrups Jun 7, 2021
fc76038
Proofread catchup messages
indrups Jun 7, 2021
132ec94
fix lost lost --no-color option in docs
kulaginm Jun 7, 2021
dc8d425
Merge branch 'release_2_5-pgpro-4850' of https://github.com/postgresp…
kulaginm Jun 7, 2021
ce34427
Pure language refinement
indrups Jun 7, 2021
5089400
fix datafile truncation bug
kulaginm Jun 7, 2021
3e43d00
Wording in documentation refined from techwriters' feedback
indrups Jun 8, 2021
55c114f
bugfix: remove unnecessary tablespace_map file write
kulaginm Jun 8, 2021
8a9c6ce
Merge branch 'release_2_5-pgpro-4850' of https://github.com/postgresp…
kulaginm Jun 8, 2021
9cde0f9
Modify tablespace preflight checks (as per comment by Roman Zharkov)
kulaginm Jun 8, 2021
1ab642a
typo
kulaginm Jun 9, 2021
6240c9f
bugfix: fix incorrect pg_control reading (as per comment by Roman Zha…
kulaginm Jun 9, 2021
1a48b0a
bugfix: add additional cmdline check (reported by Roman Zharkov)
kulaginm Jun 9, 2021
1811eb7
refine catchup tests
kulaginm Jun 10, 2021
629b732
more checks and tests
kulaginm Jun 10, 2021
b15fcf6
refine test_same_db_id test
kulaginm Jun 10, 2021
ba22e2e
split do_catchup_instance() into parts #1
kulaginm Jun 10, 2021
8d3fb16
TLI tests and TLI check fix
kulaginm Jun 10, 2021
6b6086f
postgres-9.5 compability fix
kulaginm Jun 11, 2021
ff444b3
rename tests (include simple tests to basic suite)
kulaginm Jun 11, 2021
83ccabc
add comment of future improvements
kulaginm Jun 11, 2021
4a2419a
Merge remote-tracking branch 'origin/release_2_5' into release_2_5-pg…
kulaginm Jun 14, 2021
d987131
fix help message
kulaginm Jun 15, 2021
68cfd5b
[DOC] Documentation updated upon feedback from Probackup team
indrups Jun 16, 2021
de58e46
Merge branch 'release_2_5' into release_2_5-pgpro-4850
gsmolk Jun 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ OBJS = src/utils/configuration.o src/utils/json.o src/utils/logger.o \
OBJS += src/archive.o src/backup.o src/catalog.o src/checkdb.o src/configure.o src/data.o \
src/delete.o src/dir.o src/fetch.o src/help.o src/init.o src/merge.o \
src/parsexlog.o src/ptrack.o src/pg_probackup.o src/restore.o src/show.o src/stream.o \
src/util.o src/validate.o src/datapagemap.o
src/util.o src/validate.o src/datapagemap.o src/catchup.o

# borrowed files
OBJS += src/pg_crc.o src/receivelog.o src/streamutil.o \
Expand Down
262 changes: 259 additions & 3 deletions doc/pgprobackup.xml
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,14 @@ doc/src/sgml/pgprobackup.sgml
<arg choice="plain"><option>--wal-file-name</option> <replaceable>wal_file_name</replaceable></arg>
<arg rep="repeat"><replaceable>option</replaceable></arg>
</cmdsynopsis>
<cmdsynopsis condition="12+">
<command>pg_probackup</command>
<arg choice="plain"><option>catchup</option></arg>
<arg choice="plain"><option>-b</option> <replaceable>catchup_mode</replaceable></arg>
<arg choice="plain"><option>--source-pgdata</option>=<replaceable>path_to_pgdata_on_remote_server</replaceable></arg>
<arg choice="plain"><option>--destination-pgdata</option>=<replaceable>path_to_local_dir</replaceable></arg>
<arg rep="repeat"><replaceable>option</replaceable></arg>
</cmdsynopsis>

</refsynopsisdiv>

Expand Down Expand Up @@ -283,6 +291,11 @@ doc/src/sgml/pgprobackup.sgml
Partial restore: restoring only the specified databases.
</para>
</listitem>
<listitem condition="12+">
<para>
Catchup: cloning a <productname>PostgreSQL</productname> instance for a fallen-behind standby server to <quote>catch up</quote> with master.
</para>
</listitem>
</itemizedlist>
<para>
To manage backup data, <application>pg_probackup</application> creates a
Expand Down Expand Up @@ -1076,7 +1089,8 @@ GRANT SELECT ON TABLE pg_catalog.pg_database TO backup;
mode: <xref linkend="pbk-add-instance"/>,
<xref linkend="pbk-backup"/>,
<xref linkend="pbk-restore"/>,
<xref linkend="pbk-archive-push"/>,
<phrase condition="12+"><xref linkend="pbk-catchup"/>,</phrase>
<xref linkend="pbk-archive-push"/>, and
<xref linkend="pbk-archive-get"/>.
</para>
</listitem>
Expand Down Expand Up @@ -1459,6 +1473,7 @@ pg_probackup backup -B <replaceable>backup_dir</replaceable> --instance <replace
</para>
</refsect3>
</refsect2>

<refsect2 id="pbk-verifying-a-cluster">
<title>Performing Cluster Verification</title>
<para>
Expand Down Expand Up @@ -1534,6 +1549,7 @@ pg_probackup checkdb --amcheck --skip-block-validation [<replaceable>connection_
higher cost of CPU, memory, and I/O consumption.
</para>
</refsect2>

<refsect2 id="pbk-validating-backups">
<title>Validating a Backup</title>
<para>
Expand Down Expand Up @@ -2101,6 +2117,7 @@ pg_probackup restore -B <replaceable>backup_dir</replaceable> --instance <replac
<xref linkend="pbk-restore"/>,
<xref linkend="pbk-merge"/>,
<xref linkend="pbk-delete"/>,
<phrase condition="12+"><xref linkend="pbk-catchup"/>,</phrase>
<xref linkend="pbk-checkdb"/> and
<xref linkend="pbk-validate"/> processes can be
executed on several parallel threads. This can significantly
Expand Down Expand Up @@ -3418,6 +3435,129 @@ pg_probackup delete -B <replaceable>backup_dir</replaceable> --instance <replace
</para>

</refsect2>

<refsect2 id="pbk-creating-backup-to-catchup" condition="12+">
<title>Cloning <productname>PostgreSQL</productname> Instance</title>
<para>
<application>pg_probackup</application> can create a copy of a <productname>PostgreSQL</productname>
instance directly, without using the backup catalog. This allows you
to add a new standby server in a parallel mode or to have a standby
server that has fallen behind <quote>catch up</quote> with master.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indrups
Мой рунглиш, конечно, могуч, но может такая формуливка будет звучать лучше ... or to have a fallen-behind standby server to catch with master ?

</para>

<para>
Cloning a <productname>PostgreSQL</productname> instance is different from other <application>pg_probackup</application>
processes:
<itemizedlist>
<listitem>
<para>
The backup catalog is not required.
</para>
</listitem>
<listitem>
<para>
STREAM WAL delivery mode is only supported.
</para>
</listitem>
<listitem>
<para>
Copying external directories
is not supported.
</para>
</listitem>
</itemizedlist>
</para>

<para>
Before cloning a <productname>PostgreSQL</productname> instance, set up the source database server as follows:
<itemizedlist>
<listitem>
<para>
<link linkend="pbk-configuring-the-database-cluster">Configure
the database cluster</link> for the instance to copy.
</para>
</listitem>
<listitem>
<para>
To copy from a remote server, <link linkend="pbk-configuring-the-remote-mode">configure the remote mode</link>.
</para>
</listitem>
<listitem>
<para>
To use the PTRACK backup mode, <link linkend="pbk-setting-up-ptrack-backups">set up PTRACK backups</link>.
</para>
</listitem>
</itemizedlist>
</para>

<para>
To clone a <productname>PostgreSQL</productname> instance, ensure that the source
database server is running and accepting connections and
on the server with the destination database, run the following command:
</para>
<programlisting>
pg_probackup catchup -b <replaceable>catchup-mode</replaceable> --source-pgdata=<replaceable>path_to_pgdata_on_remote_server</replaceable> --destination-pgdata=<replaceable>path_to_local_dir</replaceable> --stream [<replaceable>connection_options</replaceable>] [<replaceable>remote_options</replaceable>]
</programlisting>
<para>
Where <replaceable>catchup_mode</replaceable> can take one of the
following values: <literal>FULL</literal>, <literal>DELTA</literal>, or <literal>PTRACK</literal>.
</para>
<itemizedlist spacing="compact">
<listitem>
<para>
FULL — creates a full copy of the <productname>PostgreSQL</productname> instance.
The destination directory must be empty for this mode.
</para>
</listitem>
<listitem>
<para>
DELTA — reads all data files in the data directory and
creates an incremental copy for pages that have changed
since the destination database was shut down cleanly.
For this mode, the destination directory must contain a previous
copy of the database that was shut down cleanly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy of the database that was shut down cleanly.

А зачем именно cleanly ?

Copy link
Member Author

@kulaginm kulaginm Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Из изначальной постановки задачи в PGPRO-4447 и пункт 4 раздела Assumptions в issue #277

Copy link
Contributor

@gsmolk gsmolk Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я считаю, что такое требование сильно уменьшает юзабельность и не дает никакого профита.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Т.е. мы таким образом защищаемся от того, чтобы нам не подсунили destination, который, например, только наполовину восстановлен из бэкапа, но по-моему игра не стоит свеч, проще защититься от этого документацией.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это надо сделать в этой версии или оставим это ослабление требований на следующую версию?

Copy link
Contributor

@gsmolk gsmolk Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И, обрати внимание, мы ещё проверяем на наличие backup_label

Это хорошо, sanity чеков много не бывает. Но на 100% всё равно не защищает: вдруг pg_control успели донести, backup_label - нет.

Copy link
Member Author

@kulaginm kulaginm Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так а какие проверки в таком случае будут нормальны/достаточны?
Пока то, о чём ты говоришь -- это просто выпилить одну проверку и один тест. Но уверенности в том, что в итоге будет получен работающий инстанс базы, будет меньше

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так а какие проверки в таком случае будут нормальны/достаточны?

Ну по логике вещей, все остальные имеющиеся минус эта =)

Но уверенности в том, что в итоге будет получен работающий инстанс базы, будет меньше

Я бы не сказал

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И к тому же, сейчас комбинация двух проверок (на backup_label и на состояние pg_control) как раз защищает больше.
А вот если проверку pg_control выпилить, то как раз твой сценарий и не сможем поймать.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мой сценарий (а так же много каких други) мы и так не поймаем, поэтому мы не сильно много проигрываем в плане надежности, но сильно выигрываем в юзабельности.

</para>
</listitem>
<listitem>
<para>
PTRACK — creates an incremental backup tracking page
changes on the fly.
For this mode, the destination directory must contain a previous
copy of the database that was shut down cleanly.
</para>
</listitem>
</itemizedlist>
<para>
You can use <link linkend="pbk-connection-opts">connection_options</link> to specify
the connection to the source database cluster. If it is located on a different server,
also specify <link linkend="pbk-remote-server-opts">remote_options</link>.
If the source database contains tablespaces that must be located in
a different directory, additionally specify the <option>--tablespace-mapping</option>
option:
<programlisting>
pg_probackup catchup -b <replaceable>catchup-mode</replaceable> --source-pgdata=<replaceable>path_to_pgdata_on_remote_server</replaceable> --destination-pgdata=<replaceable>path_to_local_dir</replaceable> --stream --tablespace-mapping=<replaceable>OLDDIR</replaceable>=<replaceable>NEWDIR</replaceable>
</programlisting>
To run the <command>catchup</command> command on parallel threads, specify the number
of threads with the <option>--threads</option> option:
<programlisting>
pg_probackup catchup -b <replaceable>catchup-mode</replaceable> --source-pgdata=<replaceable>path_to_pgdata_on_remote_server</replaceable> --destination-pgdata=<replaceable>path_to_local_dir</replaceable> --stream --threads=<replaceable>num_threads</replaceable>
</programlisting>
</para>
<para>
For example, assume that a remote standby server with the <productname>PostgreSQL</productname> instance in <filename>/replica-pgdata</filename> data directory has fallen behind. To sync this instance with the one in <filename>/master-pgdata</filename> data directory, you can run
the <command>catchup</command> command in the <literal>PTRACK</literal> mode on four parallel threads as follows:
<programlisting>
pg_probackup catchup --source-pgdata=/master-pgdata --destination-pgdata=/replica-pgdata -p 5432 -d postgres -U remote-postgres-user --stream --backup-mode=PTRACK --remote-host=remote-hostname --remote-user=remote-unix-username -j 4
</programlisting>
</para>
<para>
Another example shows how you can add a new remote standby server with the <productname>PostgreSQL</productname> data directory <filename>/replica-pgdata</filename> by running the <command>catchup</command> command in the <literal>FULL</literal> mode
on four parallel threads:
<programlisting>
pg_probackup catchup --source-pgdata=/master-pgdata --destination-pgdata=/replica-pgdata -p 5432 -d postgres -U remote-postgres-user --stream --backup-mode=FULL --remote-host=remote-hostname --remote-user=remote-unix-username -j 4
</programlisting>
</para>
</refsect2>
</refsect1>

<refsect1 id="pbk-reference">
Expand Down Expand Up @@ -4290,6 +4430,120 @@ pg_probackup archive-get -B <replaceable>backup_dir</replaceable> --instance <re
For details, see section <link linkend="pbk-archiving-options">Archiving Options</link>.
</para>
</refsect3>

<refsect3 id="pbk-catchup" xreflabel="catchup" condition="12+">
<title>catchup</title>
<programlisting>
pg_probackup catchup -b <replaceable>catchup_mode</replaceable>
--source-pgdata=<replaceable>path_to_pgdata_on_remote_server</replaceable>
--destination-pgdata=<replaceable>path_to_local_dir</replaceable>
[--help] [--stream] [-j <replaceable>num_threads</replaceable>]
[-T <replaceable>OLDDIR</replaceable>=<replaceable>NEWDIR</replaceable>]
[<replaceable>connection_options</replaceable>] [<replaceable>remote_options</replaceable>]
</programlisting>
<para>
Creates a copy of a <productname>PostgreSQL</productname>
instance without using the backup catalog.

<variablelist>
<varlistentry>
<term><option>-b <replaceable>catchup_mode</replaceable></option></term>
<term><option>--backup-mode=<replaceable>catchup_mode</replaceable></option></term>
<listitem>
<para>
Specifies the catchup mode to use. Possible values are:

<itemizedlist spacing="compact">
<listitem>
<para>
<literal>FULL</literal> — creates a full copy of the <productname>PostgreSQL</productname> instance.
</para>
</listitem>
<listitem>
<para>
<literal>DELTA</literal> — reads all data files in the data directory and
creates an incremental copy for pages that have changed
since the destination database was shut down cleanly.
</para>
</listitem>
<listitem>
<para>
<literal>PTRACK</literal> — creates an incremental PTRACK backup tracking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Звучит как будто тут создается бэкап.
Должно же быть что-то вроде ".. read and copy pnly pages that changes since the point of divergence"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Такой текст пойдет?
PTRACK — tracking page changes on the fly,
only copies pages that have changed since the point of divergence
of the source and destination databases...

Copy link
Contributor

@gsmolk gsmolk Jun 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Звучит норм!

Такой текст пойдет?
PTRACK — tracking page changes on the fly,
only copies pages that have changed since the point of divergence
of the source and destination databases...

Мне кажется, очень важно добавить, что и читаются тоже только изменившие страницы

page changes on the fly.
</para>
</listitem>
</itemizedlist>
</para>
</listitem>
</varlistentry>

<varlistentry>
<term><option>--source-pgdata=<replaceable>path_to_pgdata_on_remote_server</replaceable></option></term>
<listitem>
<para>
Specifies the path to the data directory of the instance to be copied. The path can be local or remote.
</para>
</listitem>
</varlistentry>

<varlistentry>
<term><option>--destination-pgdata=<replaceable>path_to_local_dir</replaceable></option></term>
<listitem>
<para>
Specifies the path to the local data directory to copy to.
</para>
</listitem>
</varlistentry>

<varlistentry>
<term><option>--stream</option></term>
<listitem>
<para>
Makes a <link linkend="pbk-stream-mode">STREAM</link> backup, which
includes all the necessary WAL files by streaming them from
the database server via replication protocol.
</para>
</listitem>
</varlistentry>

<varlistentry>
<term><option>-j <replaceable>num_threads</replaceable></option></term>
<term><option>--threads=<replaceable>num_threads</replaceable></option></term>
<listitem>
<para>
Sets the number of parallel threads for
<command>catchup</command> process.
</para>
</listitem>
</varlistentry>

<varlistentry>
<term><option>-T <replaceable>OLDDIR</replaceable>=<replaceable>NEWDIR</replaceable></option></term>
<term><option>--tablespace-mapping=<replaceable>OLDDIR</replaceable>=<replaceable>NEWDIR</replaceable></option></term>
<listitem>
<para>
Relocates the tablespace from the <replaceable>OLDDIR</replaceable> to the <replaceable>NEWDIR</replaceable>
directory at the time of recovery. Both <replaceable>OLDDIR</replaceable> and <replaceable>NEWDIR</replaceable> must
be absolute paths. If the path contains the equals sign (<literal>=</literal>),
escape it with a backslash. This option can be specified
multiple times for multiple tablespaces.
</para>
</listitem>
</varlistentry>

</variablelist>
</para>

<para>
Additionally, <link linkend="pbk-connection-opts">connection
options</link>, <link linkend="pbk-remote-server-opts">remote
mode options</link> can be used.
</para>
<para>
For details on usage, see the section
<link linkend="pbk-creating-backup-to-catchup">Cloning <productname>PostgreSQL</productname> Instance</link>.
</para>
</refsect3>
</refsect2>
<refsect2 id="pbk-options">
<title>Options</title>
Expand Down Expand Up @@ -4679,7 +4933,7 @@ pg_probackup archive-get -B <replaceable>backup_dir</replaceable> --instance <re
<term><option>--no-color</option></term>
<listitem>
<para>
Disable the coloring for console log messages of <literal>warning</literal> and <literal>error</literal> levels.
Disable coloring for console log messages of <literal>warning</literal> and <literal>error</literal> levels.
</para>
</listitem>
</varlistentry>
Expand Down Expand Up @@ -4832,7 +5086,8 @@ pg_probackup archive-get -B <replaceable>backup_dir</replaceable> --instance <re
<title>Connection Options</title>
<para>
You can use these options together with
<xref linkend="pbk-backup"/> and
<xref linkend="pbk-backup"/>
<phrase condition="12+">, <xref linkend="pbk-catchup"/>,</phrase> and
<xref linkend="pbk-checkdb"/> commands.
</para>
<para>
Expand Down Expand Up @@ -5123,6 +5378,7 @@ pg_probackup archive-get -B <replaceable>backup_dir</replaceable> --instance <re
used with <xref linkend="pbk-add-instance"/>,
<xref linkend="pbk-set-config"/>,
<xref linkend="pbk-backup"/>,
<phrase condition="12+"><xref linkend="pbk-catchup"/>,</phrase>
<xref linkend="pbk-restore"/>,
<xref linkend="pbk-archive-push"/>, and
<xref linkend="pbk-archive-get"/> commands.
Expand Down
2 changes: 1 addition & 1 deletion src/archive.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ do_archive_push(InstanceState *instanceState, InstanceConfig *instance, char *wa
elog(ERROR, "getcwd() error");

/* verify that archive-push --instance parameter is valid */
system_id = get_system_identifier(current_dir);
system_id = get_system_identifier(current_dir, FIO_DB_HOST);

if (instance->pgdata == NULL)
elog(ERROR, "Cannot read pg_probackup.conf for this instance");
Expand Down
Loading