Skip to content

Load configuration in post_parse_analyze hook #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2016
Merged

Load configuration in post_parse_analyze hook #3

merged 1 commit into from
Mar 21, 2016

Conversation

rjuju
Copy link
Contributor

@rjuju rjuju commented Mar 19, 2016

Hello,

During testing, I found a corner case issue. If the first query executed on the cluster after a restart is a DROP TABLE of a partitionned table, it'll fail because the configuration will be loaded after the effective drop, but with the pathman_config table not up to date.

This commit moves the load_config() call to post_parse_analyze hook, which is also called for utility statement. If the overhead of calling a hook for every query just for this purpose is too much, ProcessUtility hook could be used instead, but the load_config() call would be duplicated. Let me know what you prefer.

Regards

@zilder zilder merged commit 006850e into postgrespro:master Mar 21, 2016
@zilder
Copy link
Collaborator

zilder commented Mar 21, 2016

Thanks again, I appreciate your help : ) I've merged your patch to master!

@rjuju
Copy link
Contributor Author

rjuju commented Mar 21, 2016

Thanks Ildar :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants