Skip to content

Added 4 translation keys in two files #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

WillyKirchner
Copy link

@WillyKirchner WillyKirchner commented Aug 30, 2022

  • solving issue missing translation keys #1168
  • for my usecase of the react-chart-editor i needed translation, and discovered strings which aren't keys.
  • I changed keys in two lines of ColorPicker.js and one line in DataSelector.js and added the localize variable
  • after that i ran the scripts to integrate the keys in the translation-key files

@WillyKirchner
Copy link
Author

@dmt0 there are checks failing. Could you point me to the issues for the checks? What would it take to merge this pull request?

@dmt0
Copy link
Contributor

dmt0 commented Sep 7, 2023

Hi @WillyKirchner sorry for the huge delay and thanks for your contribution! I couldn't get the CI to work on this branch, maybe because the job is super stale. I did include your changes in my #1172. Release is coming soon. I'm gonna close this for now.

@dmt0 dmt0 closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants