Skip to content

Remove plot.ly URL in exported HTML if user didn't enable link or sendToCloud #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Remove plot.ly URL in exported HTML if user didn't enable link or sendToCloud #1628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions packages/python/plotly/plotly/io/_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ def to_html(
# Set responsive
config.setdefault("responsive", True)

jconfig = json.dumps(config)

# Get div width/height
layout_dict = fig_dict.get("layout", {})
template_dict = fig_dict.get("layout", {}).get("template", {}).get("layout", {})
Expand All @@ -177,7 +175,22 @@ def to_html(
div_height = str(div_height) + "px"

# ## Get platform URL ##
plotly_platform_url = config.get("plotlyServerURL", "https://plot.ly")
if config.get("showLink", False) or config.get("showSendToCloud", False):
# Figure is going to include a Chart Studio link or send-to-cloud button,
# So we need to configure the PLOTLYENV.BASE_URL property
base_url_line = """
window.PLOTLYENV.BASE_URL='{plotly_platform_url}';\
""".format(
plotly_platform_url=config.get("plotlyServerURL", "https://plot.ly")
)
else:
# Figure is not going to include a Chart Studio link or send-to-cloud button,
# In this case we don't want https://plot.ly to show up anywhere in the HTML
# output
config.pop("plotlyServerURL", None)
config.pop("linkText", None)
config.pop("showLink", None)
base_url_line = ""

# ## Build script body ##
# This is the part that actually calls Plotly.js
Expand Down Expand Up @@ -214,6 +227,9 @@ def to_html(
id=plotdivid, animation_opts=animation_opts_arg
)

# Serialize config dict to JSON
jconfig = json.dumps(config)

script = """
if (document.getElementById("{id}")) {{
Plotly.newPlot(
Expand Down Expand Up @@ -331,8 +347,7 @@ def to_html(
style="height:{height}; width:{width};"></div>
<script type="text/javascript">
{require_start}
window.PLOTLYENV=window.PLOTLYENV || {{}};
window.PLOTLYENV.BASE_URL='{plotly_platform_url}';
window.PLOTLYENV=window.PLOTLYENV || {{}};{base_url_line}
{script};
{require_end}
</script>
Expand All @@ -342,7 +357,7 @@ def to_html(
id=plotdivid,
width=div_width,
height=div_height,
plotly_platform_url=plotly_platform_url,
base_url_line=base_url_line,
require_start=require_start,
script=script,
require_end=require_end,
Expand Down