Skip to content

Add issue and PR template from CONTRIBUTING.md #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2016
Merged

Conversation

rreusser
Copy link
Contributor

I've copied with very little modification the guidelines from CONTRIBUTING.md. The goal is to elevate the guidelines to a higher level of visibility so that people are more effectively steered toward the forum or good practices. Hopefully will save some repetitive back and forth for @etpinard.

Modify as needed. 👍

@@ -0,0 +1,15 @@
Thanks for your interest in plotly.js!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I think this file needs to be named PULL_REQUEST_TEMPLATE.md according to https://github.com/blog/2111-issue-and-pull-request-templates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. My mistake. Got in a hurry. Fixed.

@etpinard
Copy link
Contributor

💃 merge away test have passed.

@rreusser
Copy link
Contributor Author

rreusser commented Jul 19, 2016

I'm seeing one failed, but looks like the intermittent double-click thing. (I mean obv nothing caused by this, but y'know…)

@rreusser rreusser merged commit f8b35f8 into master Jul 19, 2016
@etpinard etpinard deleted the issue-pr-templates branch July 20, 2016 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants