Skip to content

Keep hidden grid lines of oriented traces when color is defined by template #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 22, 2020

Fixes #4980 | demo

@plotly/plotly_js
cc: @wbrgss

TODO:

  • add test

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Jul 22, 2020
@wbrgss
Copy link
Contributor

wbrgss commented Jul 22, 2020

At first glance this seems to solve the problem I described in #4980 (comment) out-of-the-box (i.e. without changes to the relevant template)

I'm using https://82470-45646037-gh.circle-artifacts.com/0/dist/plotly.min.js from the publish step of this PR

Much appreciated @archmoj!

@archmoj
Copy link
Contributor Author

archmoj commented Jul 22, 2020

🥇 @wbrgss thanks very much for tying that out.
To catch similar issues in future, I think, it may be a good idea if we could add a number of mocks (for image test on the plotly.js repo) that use the exact templates applied by DDK.

@archmoj archmoj requested a review from alexcjohnson July 23, 2020 14:19
@alexcjohnson
Copy link
Collaborator

Per our discussion just now: In the short term this leaves too many open questions for us to feel confident about the solution. So the steps @archmoj is going to take are:

@archmoj
Copy link
Contributor Author

archmoj commented Jul 23, 2020

Closing not that #5016 is open.

@archmoj archmoj closed this Jul 23, 2020
@archmoj archmoj deleted the fix-hide-grid-lines branch July 23, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template quirk
3 participants