-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Orthographic projection for 3D plots #3331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test 3d-view-controls fork
@archmoj how close is this one to being |
Wanna try to merge master and resolve the conflict instead? Keeping just one PR in our github history. Thanks! |
2 tasks
Now in #3550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2611.
A new attribute
ortho
is defined on the camera object and passed to various modules.The scene initialisation is now uses the camera init variables and
createCamera
is centralised in a separate module (i.e.3d-view
) as it was used byplotly.js
as well as3d-view-controls
&gl-plot3d
modules.This is a work in progress and some functions such as zooming and restyle require improvements.
Hint: to quickly test the functionality of this feature with existing 3-D mocks, one may change the
dflt
ofortho
to be equal totrue
.@etpinard