Skip to content

Swap canvases #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Swap canvases #2367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/traces/scattergl/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ function sceneOptions(container, subplot, trace, positions) {
if(multiMarker || Array.isArray(markerOpts.color) || Array.isArray(markerOpts.line.color) || Array.isArray(markerOpts.line) || Array.isArray(markerOpts.opacity)) {
markerOptions.colors = new Array(count);
markerOptions.borderColors = new Array(count);

var colors = formatColor(markerOpts, markerOpts.opacity, count);
var borderColors = formatColor(markerOpts.line, markerOpts.opacity, count);

Expand Down Expand Up @@ -590,6 +591,7 @@ function sceneUpdate(container, subplot) {
// draw traces in proper order
scene.draw = function draw() {
var i;

for(i = 0; i < scene.count; i++) {
if(scene.fill2d) scene.fill2d.draw(i);
}
Expand Down Expand Up @@ -767,7 +769,7 @@ function plot(container, subplot, cdata) {
});
});

var regl = layout._glcanvas.data()[0].regl;
var regl = layout._glcanvas.data()[1].regl;

// that is needed for fills
linkTraces(container, subplot, cdata);
Expand Down Expand Up @@ -963,12 +965,12 @@ function plot(container, subplot, cdata) {
// create select2d
if(!scene.select2d) {
// create scatter instance by cloning scatter2d
scene.select2d = createScatter(layout._glcanvas.data()[1].regl, {clone: scene.scatter2d});
scene.select2d = createScatter(layout._glcanvas.data()[0].regl, {clone: scene.scatter2d});
}

// update only traces with selection
scene.scatter2d.update(scene.unselectedOptions.map(function(opts, i) {
return scene.selectBatch[i] ? opts : null;
return scene.selectBatch[i] !== null ? opts : null;
}));
scene.select2d.update(scene.markerOptions);
scene.select2d.update(scene.selectedOptions);
Expand Down