Reflect scatter3d marker opacity reality in attributes #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which reflects the logic in the convert step - add custom description for scatter3d marker.opacity
| 'must be a scalar value for performance reasons.', | ||
| 'To set a blending opacity value', | ||
| '(i.e. which is not transparent), set *marker.color*', | ||
| 'to an rgba color and use its alpha channel.' |
There was a problem hiding this comment.
@cldougl I could use a proof reader.
|
💃 |
etpinard
added a commit
that referenced
this pull request
Dec 17, 2015
Reflect scatter3d marker opacity reality in attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cldougl @mdtusz
marker.opacityin scatter3d traces must a be scalar. That is, it doesn't support arrays of scalar like itsscattercounterpart. We made this decision for performance reasons. Marker opacity arrays would require an extra pass over the data on every render loop.Before this PR, this coercion was made here but wasn't reflected in the scatter3d trace attributes.