Skip to content

Config argument for baseUrl #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chriddyp opened this issue Jun 27, 2018 · 1 comment
Closed

Config argument for baseUrl #2759

chriddyp opened this issue Jun 27, 2018 · 1 comment
Labels
feature something new

Comments

@chriddyp
Copy link
Member

Right now, the base url for the /external endpoint is taken from the window. Could we add an option to the config as well? That'd make it easier for Dash users to point to their On-Premise instances:

var baseUrl = (window.PLOTLYENV && window.PLOTLYENV.BASE_URL) || 'https://plot.ly';

something like

 var baseUrl = (
    (window.PLOTLYENV && window.PLOTLYENV.BASE_URL) || 
    config.plotly_server_url ||
    'https://plot.ly';

cc @cldougl

@etpinard
Copy link
Contributor

Sure. 🐫 that config option to plotlyServerUrl and PR away 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

No branches or pull requests

2 participants